From: Don Slutz Date: Mon, 23 Mar 2015 15:53:44 +0000 (+0100) Subject: x86/hvm: prevent gcc uninitialised var warning X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~3540 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https://%22%22/%22http:/www.example.com/cgi/%22https:/%22%22?a=commitdiff_plain;h=ffdb781883abd3215287ba1b1853f3d437d1240c;p=xen.git x86/hvm: prevent gcc uninitialised var warning gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3 reports: ---------------------------------------------------------------------- hvm.c: In function `hvm_create_ioreq_server': hvm.c:487:18: error: `bufioreq_pfn' may be used uninitialised in this function [-Werror=uninitialized] hvm.c:718:30: note: `bufioreq_pfn' was declared here ---------------------------------------------------------------------- My code analysis says that gcc is wrong, but initilize the variable to prevent the gcc warning. Reported-by: Ian Murray Signed-off-by: Don Slutz --- diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 4734d7112f..dd6b0d0e3d 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -733,7 +733,8 @@ static int hvm_ioreq_server_map_pages(struct hvm_ioreq_server *s, bool_t is_default, bool_t handle_bufioreq) { struct domain *d = s->domain; - unsigned long ioreq_pfn, bufioreq_pfn; + unsigned long ioreq_pfn; + unsigned long bufioreq_pfn = ~0UL; /* gcc uninitialised var warning */ int rc; if ( is_default )